Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: createLogger & commond-core support multi provider #604

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

echosoar
Copy link
Member

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Aug 18, 2020

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #604 into serverless will decrease coverage by 0.03%.
The diff coverage is 60.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           serverless     #604      +/-   ##
==============================================
- Coverage       80.43%   80.39%   -0.04%     
==============================================
  Files             100      100              
  Lines            3848     3852       +4     
  Branches          519      521       +2     
==============================================
+ Hits             3095     3097       +2     
- Misses            747      749       +2     
  Partials            6        6              
Impacted Files Coverage Δ
packages/runtime-engine/src/lib/loggerFactory.ts 90.00% <50.00%> (-10.00%) ⬇️
packages/faas-cli-command-core/src/core.ts 81.89% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e874a2...0b84f94. Read the comment docs.

@czy88840616 czy88840616 merged commit c1748f0 into serverless Aug 18, 2020
@czy88840616 czy88840616 deleted the fix/createLoagger branch August 18, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants