Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on Updated Data for US #2

Open
rylanb opened this issue Jan 27, 2018 · 5 comments
Open

Question on Updated Data for US #2

rylanb opened this issue Jan 27, 2018 · 5 comments
Labels

Comments

@rylanb
Copy link

rylanb commented Jan 27, 2018

Expected Behavior

80108 / 80109 zipcodes exist in the all_us_zipcodes.csv file and can be updated via https://github.com/midwire/my_zipcode_gem scripts.

Actual Behavior

80108 / 80109 and other zipcodes (likely) do exist and can populate / keep data up-to-date for production systems.

There is -> 80104,Castle Rock,CO,DOUGLAS,,39.374779,-104.849988 in the data, which is great, but there are more zip codes that represent Castle Rock, CO.

Steps to reproduce the problem

Go to https://raw.githubusercontent.com/midwire/free_zipcode_data/master/all_us_zipcodes.csv
and search for 80108 and/or 80109 and notice that Castle Rock, CO is not in that CSV file.

If you download the data from Geonames, those are in the US.txt file in the US.zip.

I'm more than happy to work on this gem and the my_zipcode_gem to help keep things up-to-date but I find it confusing that the all_us_zipcodes.csv is generated from the my_zipcode_gem and is now 3 months out of date. What's the process for running that properly with new data and updating?

Thanks for your work on this gem, it has gotten us very far on our production application!


  • Current Version: Cloned direct from master
  • Operating System: Mac OS X 10.11.6
@rylanb
Copy link
Author

rylanb commented Jan 27, 2018

As an addendum to this that is slightly related:

When I tried to grab the data and create my own CSV I had errors around County names in the US.txt file:

Aleutians West (CA) and Anchorage Municipality for importing with the https://github.com/midwire/my_zipcode_gem/blob/master/lib/generators/my_zipcode_gem/templates/zipcodes.rake rake task.

Does the my_zipcode_gem sanitize those somehow that I'm missing?

Thanks again!

@midwire
Copy link
Owner

midwire commented Apr 18, 2018

@rylanb I apologize for the late reply. I’ve been using another github account for a specific client project and apparently turned of notifications for this one. We are considering a refactor, and if you are willing to join @cmckni3 and myself in maintaining this you are a welcome addition. I have to run to a meeting but will respond more later.

@cmckni3
Copy link
Collaborator

cmckni3 commented Apr 18, 2018

I can look into it when I can. At ng-conf this week though.

@rylanb
Copy link
Author

rylanb commented Apr 20, 2018

@midwire No big deal!

I'd be happy to try and help out. I do already do some OSS maintaining. Please do include me when you start looking at a refactor or re-write! Love to try and work it in, if I can!

@midwire
Copy link
Owner

midwire commented Apr 21, 2018

FYI: This is related to Issue #4 and will be resolved as part of our ongoing refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants