Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing close button for inline elements in some cases #104

Closed
viliusle opened this issue Dec 20, 2022 · 2 comments
Closed

missing close button for inline elements in some cases #104

viliusle opened this issue Dec 20, 2022 · 2 comments

Comments

@viliusle
Copy link
Collaborator

If users will open modal dialog on Inline HTML elements, close button may not be visible if matching all conditions below:

  1. at least if device is mobile android (chrome). Sadly chrome mobile emulator does not reproduce this bug !
  2. inline dialog has lots of content (scrollbar activates).

To reproducer it:

  1. edit https://midzer.github.io/tobii/demo/ and add lots of content for "Inline HTML" section to force scrollbar to appear.
  2. open it on mobile (android, Chrome) and open "Inline HTML" modal window
  3. most of close button will not be visible .

What happens?

There is CSS rule .tobii__slide [data-type] with value of:
max-height: var(--slide-max-height); or max-height: calc(100vh - 2.77778em). Because this element is centered, layout shifts to top and hides most of close button. But I can not understand why desktop chrome and mobile chrome renders this situation in different ways.

Possible solution

Replace above line to:
max-width: 100%.

p.s. more testing must be made before this can be updated.

@viliusle viliusle changed the title missing close button on for inline elements missing close button for inline elements in some cases Dec 20, 2022
@viliusle
Copy link
Collaborator Author

viliusle commented Dec 20, 2022

Related:

  • demo should be updated and more content should be added to "Inline HTML" section to simulate real world situation.
  • "YouTube: (mode: iframe)" on demo does not work. Find better video, that will not be deleted in next 5 years (good luck here...)

@midzer
Copy link
Owner

midzer commented Dec 26, 2022

Hi @viliusle. Thanks for filing!

Let's try your proposed solution in develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants