Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule libsigmf? #181

Closed
miek opened this issue Feb 27, 2021 · 2 comments
Closed

Submodule libsigmf? #181

miek opened this issue Feb 27, 2021 · 2 comments

Comments

@miek
Copy link
Owner

miek commented Feb 27, 2021

It might be a good idea to submodule libsigmf rather than making users (& package maintainers) install it for SigMF support

@schneider42
Copy link
Collaborator

@Sec42 recently had quite a hard time installing libsigmf into his (pybombs) installation. I think he might have some input here.

@Sec42
Copy link
Contributor

Sec42 commented Mar 2, 2021

I'm not sure if it's really applicable to this question of using a submoduleor not.

I had trouble building it in a pybombs environment. To get it to build cleanly I had to use specific (old) versions of flatbuffers & nlohmann_json.

source: git+https://github.com/google/flatbuffers
gitrev: 71aca81ff9

and

source: git+https://github.com/nlohmann/json.git
gitbranch: v3.7.1

@miek miek closed this as completed Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants