Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in decode #106

Closed
armon opened this issue Aug 22, 2014 · 5 comments
Closed

Panic in decode #106

armon opened this issue Aug 22, 2014 · 5 comments

Comments

@armon
Copy link
Contributor

armon commented Aug 22, 2014

This is from a downstream issue: hashicorp/consul#284

Looks like there is an issue in dns.unpackStructValue that can cause a panic. That ticket has all the information I know about this currently.

@miekg
Copy link
Owner

miekg commented Aug 22, 2014

Ack. Looking.
On 22 Aug 2014 20:55, "Armon Dadgar" notifications@github.com wrote:

This is from a downstream issue: hashicorp/consul#284
hashicorp/consul#284

Looks like there is an issue in dns.unpackStructValue that can cause a
panic. That ticket has all the information I know about this currently.


Reply to this email directly or view it on GitHub
#106.

@miekg
Copy link
Owner

miekg commented Aug 22, 2014

Do you know which git version of go dns you are using? Then I can make sense of the line numbers.

@armon
Copy link
Contributor Author

armon commented Aug 22, 2014

Should be 9af5c1f

@miekg
Copy link
Owner

miekg commented Aug 22, 2014

Ok, still think it is off so my patch in hashicorp/consul#284 should do something. Without a testcase it is hard to tell of course.

@armon
Copy link
Contributor Author

armon commented Aug 22, 2014

Cool, I'm going to see if we can get this reproduced.

@miekg miekg closed this as completed in 8fecf17 Aug 23, 2014
@miekg miekg reopened this Aug 24, 2014
@miekg miekg closed this as completed Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants