edns makeDataOpt function needs to assign the code value

[mosajjal]

Just need to confirm this with you first; before working on a potential PR.

in most of EDNS0 comments (like here) you've mentioned e.Code needs to be explicitly set. However, in here none of the codes are present so the packed/unpacked version will always have value 0 for Code.

[miekg]

Had to double check, but it's filed in from the wire here: https://github.com/miekg/dns/blob/master/msg_helpers.go#L427

Unsure if it make sense to add a comment to makeDataOpt?

[mosajjal]

aaah now it makes more sense. thanks for the clarification. you reckon it'll be useful to add a comment here mentioning "it's unpacked from the wire" or just leave it as it is?

[miekg]

Seems to warrent a comment. Please send a PR. Cheers!

…

On Thu, 5 Jan 2023, 21:47 Ali Mosajjal, ***@***.***> wrote: aaah now it makes more sense. thanks for the clarification. you reckon it'll be useful to add a comment here <https://github.com/miekg/dns/blob/4bd038eb7616bf9225289bdfb58f4de1e6f55751/edns.go#L266> mentioning "it's unpacked from the wire" or just leave it as it is? — Reply to this email directly, view it on GitHub <#1407 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACWIW3SO5FRRCENTPYZHADWQ4XOTANCNFSM6AAAAAATRMR264> . You are receiving this because you commented.Message ID: ***@***.***>