Adds function ExchangeWithConn #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a connection instead of having the library create a new one for them. Exchange now wraps around this, implementing the existing behavior by creating a new connection and passing it to ExchangeWithConn. c.exchange has been updated to support this behavior as well.
Codecov Report
@@ Coverage Diff @@
## master #1110 +/- ##
=======================================
Coverage 55.59% 55.60%
=======================================
Files 41 41
Lines 10067 10068 +1
=======================================
+ Hits 5597 5598 +1
Misses 3441 3441
Partials 1029 1029
Continue to review full report at Codecov.
|
|
this looks good, thank you /lgtm |
![cbot[bot]](https://avatars.githubusercontent.com/u/353371?s=60&v=4){kind=small}
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
* Implements ExchangeWithConn, a function that allows callers to pass in a connection instead of having the library create a new one for them. Exchange now wraps around this, implementing the existing behavior by creating a new connection and passing it to ExchangeWithConn. c.exchange has been updated to support this behavior as well. * adding tab * formatting problem * adds test case for ExchangeWithConn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#614 requested that connection reuse be implemented in this library to help improve performance when using TCP/TCP-TLS connections. This was rejected, fairly, because of the complexity in handling that logic within the library. This PR would solve the problem without introducing connection management code into the library at all. Instead it does some minor refactoring in order to expose the ability for the caller to manage connections and pass them in to the library via the ExchangeWithConn function. The existing Exchange behavior is preserved, so backwards compatibility shouldn't be an issue.