Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in edns.go #1162

Closed
wants to merge 1 commit into from
Closed

Fix typo in edns.go #1162

wants to merge 1 commit into from

Conversation

muesli
Copy link

@muesli muesli commented Oct 1, 2020

"implementes" => "implements"

"implementes" => "implements"
@codecov-commenter
Copy link

Codecov Report

Merging #1162 into master will decrease coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
- Coverage   55.89%   54.44%   -1.45%     
==========================================
  Files          41       41              
  Lines       10141     9141    -1000     
==========================================
- Hits         5668     4977     -691     
+ Misses       3468     3159     -309     
  Partials     1005     1005              
Impacted Files Coverage Δ
edns.go 25.55% <ø> (-2.01%) ⬇️
update.go 58.97% <0.00%> (-12.96%) ⬇️
duplicate.go 28.57% <0.00%> (-8.93%) ⬇️
serve_mux.go 70.27% <0.00%> (-5.29%) ⬇️
listen_go111.go 73.33% <0.00%> (-4.45%) ⬇️
msg_helpers.go 64.00% <0.00%> (-4.21%) ⬇️
zmsg.go 36.15% <0.00%> (-3.88%) ⬇️
acceptfunc.go 42.85% <0.00%> (-3.81%) ⬇️
xfr.go 29.45% <0.00%> (-3.17%) ⬇️
msg.go 73.80% <0.00%> (-2.73%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5f112...17fad32. Read the comment docs.

@miekg
Copy link
Owner

miekg commented Oct 1, 2020

I've been here before. I'm not going to merge single typo PRs. Only a large one that fixes a whole bunch of typos.

sorry

@miekg miekg closed this Oct 1, 2020
@muesli
Copy link
Author

muesli commented Oct 1, 2020

It's the only typo I've found 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants