Added support for ENUM Source-URI Extension #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miekg
approved these changes
Sep 27, 2021
|
Note that option code 4 is reserved for draft-cheshire-edns0-owner-option, see: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-11 Oracle (ab)uses this option code in their Acme Packet Source URI Information in ENUM Requests implementation. Heuristics may be needed to support both drafts in the future. |
|
[ Quoting ***@***.***> in "Re: [miekg/dns] Added support for E..." ]
Note that option code 4 is reserved for draft-cheshire-edns0-owner-option, see:
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#
dns-parameters-11
Oracle (ab)uses this option code in their Acme Packet Source URI Information in
ENUM Requests implementation.
Heuristics may be needed to support both drafts in the future.
interesting... that should be sorted at the iana level at some point. We will not add
heuristics to detect things here, only one implementation can claim this code point.
/Miek
…--
Miek Gieben
|
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Miek,
Added the ENUM Source-URI Extension described here: https://datatracker.ietf.org/doc/html/draft-kaplan-enum-source-uri-00
Thanks for this great project!