Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not sign BADKEY and BADSIG TSIG error responses #1316

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Do not sign BADKEY and BADSIG TSIG error responses #1316

merged 3 commits into from
Dec 20, 2021

Commits on Dec 3, 2021

  1. Per RFC 8945 5.3.2, responses with BADKEY and BADSIG errors must not … 

    …be signed.

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
    @chrisohaver
    chrisohaver committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    a695a65 View commit details
    Browse the repository at this point in the history

  2. refactor to remove else block 

    Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
    @chrisohaver
    chrisohaver committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    06539e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. skip signing only for BADKEY and BADSIG 

    Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
    @chrisohaver
    chrisohaver committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    ea39b22 View commit details
    Browse the repository at this point in the history