Little fix #14
Merged
Little fix #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. looks much better indeed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going nuts trying to work out why dnssec validation on the root zone wasn't working. Turns out that there's a nasty interaction between the use of "" as the root domain (UnpackDomainName does this) and the way SplitLabels treats that string (as a single label, not zero labels). While fixing SplitLabels was an option, I think the better option is just to use "." properly to start with. This triggered a bug in "base64" string unpack for RRSIG because we were making assumptions about the way domain names unpack. I replaced that code with much safer code. :)