Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExchangeWithConnContext public #1459

Merged
merged 1 commit into from
Jun 19, 2023

Commits on May 10, 2023

  1. Make ExchangeWithConnContext public

    If we want to use a custom mechanism of obtaining a Conn that doesn't
    match the net.Dialer type, but retain the timeout behaviour from
    ExchangeContext, there was previously no way to accomplish this.
    
    This PR makes the underlying ExchangeWithConnContext function public,
    which allows this behaviour.
    
    Now that miekg#1454 is merged, there is no longer any interaction between the
    context provided and the singleflight behaviour, so I removed the
    comment from ExchangeWithConn.
    
    Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
    andrew-d committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6a326b0 View commit details
    Browse the repository at this point in the history