Remove redundant parenthesis

[tmthrgd]

These were caught with:

gofmt -r '(a) -> a' -w *.go

---

I decided to exclude the following change because, although it is correct, it doesn't look as clear to me. I can include it if you disagree.

diff --git a/msg_helpers_test.go b/msg_helpers_test.go
index adceb882c5..dccc539248 100644
--- a/msg_helpers_test.go
+++ b/msg_helpers_test.go
@@ -92,7 +92,7 @@ func TestPackDataNsec(t *testing.T) {
        for _, tt := range tests {
                t.Run(tt.name, func(t *testing.T) {
                        got, err := packDataNsec(tt.args.bitmap, tt.args.msg, tt.args.off)
-                       if (err != nil) != tt.wantErr {
+                       if err != nil != tt.wantErr {
                                t.Errorf("packDataNsec() error = %v, wantErr %v", err, tt.wantErr)
                                return
                        }

[codecov-io]

Codecov Report

Merging #727 into master will decrease coverage by 0.03%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   55.76%   55.72%   -0.04%     
==========================================
  Files          39       39              
  Lines       10745    10745              
==========================================
- Hits         5992     5988       -4     
- Misses       3670     3673       +3     
- Partials     1083     1084       +1

Impacted Files	Coverage Δ
labels.go	93.39% <100%> (ø)	⬆️
scan_rr.go	68.88% <100%> (ø)	⬆️
dnssec.go	58.27% <100%> (ø)	⬆️
client.go	58.8% <100%> (ø)	⬆️
types.go	68.2% <100%> (ø)	⬆️
msg.go	78.71% <100%> (-0.63%)	⬇️
edns.go	14.94% <100%> (ø)	⬆️
server.go	62% <100%> (ø)	⬆️
msg_helpers.go	52.16% <75%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208cd1e...e4dac0a. Read the comment docs.

[miekg]

Lgtm. Just do it fully as the code is in a test.

…

On Thu, 16 Aug 2018, 10:24 Tom Thorogood, ***@***.***> wrote: These were caught with: gofmt -r '(a) -> a' -w *.go ------------------------------ I decided to exclude the following change because, although it is correct, it doesn't look as clear to me. I can include it if you disagree. diff --git a/msg_helpers_test.go b/msg_helpers_test.go index adceb882c5..dccc539248 100644--- a/msg_helpers_test.go+++ b/msg_helpers_test.go@@ -92,7 +92,7 @@ func TestPackDataNsec(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { got, err := packDataNsec(tt.args.bitmap, tt.args.msg, tt.args.off)- if (err != nil) != tt.wantErr {+ if err != nil != tt.wantErr { t.Errorf("packDataNsec() error = %v, wantErr %v", err, tt.wantErr) return } ------------------------------ You can view, comment on, or merge this pull request online at: #727 Commit Summary - Remove redundant parenthesis - Remove more redundant parenthesis File Changes - *M* client.go <https://github.com/miekg/dns/pull/727/files#diff-0> (2) - *M* client_test.go <https://github.com/miekg/dns/pull/727/files#diff-1> (4) - *M* dns_test.go <https://github.com/miekg/dns/pull/727/files#diff-2> (2) - *M* dnssec.go <https://github.com/miekg/dns/pull/727/files#diff-3> (6) - *M* edns.go <https://github.com/miekg/dns/pull/727/files#diff-4> (8) - *M* labels.go <https://github.com/miekg/dns/pull/727/files#diff-5> (4) - *M* msg.go <https://github.com/miekg/dns/pull/727/files#diff-6> (16) - *M* msg_helpers.go <https://github.com/miekg/dns/pull/727/files#diff-7> (8) - *M* scan_rr.go <https://github.com/miekg/dns/pull/727/files#diff-8> (6) - *M* server.go <https://github.com/miekg/dns/pull/727/files#diff-9> (2) - *M* types.go <https://github.com/miekg/dns/pull/727/files#diff-10> (18) Patch Links: - https://github.com/miekg/dns/pull/727.patch - https://github.com/miekg/dns/pull/727.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#727>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVkWyoTohy9DW4Og99hN9r1_ftL_p3Rks5uRSwogaJpZM4V_aaj> .