ignore Z flag in queries, clear Z flag in automatic replies #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
==========================================
+ Coverage 55.48% 55.52% +0.03%
==========================================
Files 42 42
Lines 9923 9922 -1
==========================================
+ Hits 5506 5509 +3
+ Misses 3389 3387 -2
+ Partials 1028 1026 -2
Continue to review full report at Codecov.
|
chantra
reviewed
May 22, 2019
| @@ -571,6 +571,7 @@ func (srv *Server) serveDNS(m []byte, w *response) { | |||
| req.SetRcodeFormatError(req) | |||
| // Are we allowed to delete any OPT records here? | |||
| req.Ns, req.Answer, req.Extra = nil, nil, nil | |||
| req.Zero = false | |||
There was a problem hiding this comment.
while this is not currently explicitly tested, it seems like a good default when rejecting the message.
|
The excessive testing code removed, leaving with the only two checks for the aspects this diff changes. @miekg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context in issue #975.
cc @chantra