Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: RFC7512 URI support #170

Closed
dwmw2 opened this issue Jun 19, 2023 · 2 comments
Closed

RFE: RFC7512 URI support #170

dwmw2 opened this issue Jun 19, 2023 · 2 comments

Comments

@dwmw2
Copy link

dwmw2 commented Jun 19, 2023

https://github.com/stefanberger/go-pkcs11uri adds support for parsing and handling PKCS#11 URIs, but we could do with better integration. In particular, matching tokens and objects against criteria given in a URI.

In https://github.com/dwmw2/rolesanywhere-credential-helper/blob/pkcs11/aws_signing_helper/pkcs11_signer.go I've had to implement functions like matchSlots to return the slots matching a given URI, and getFindTemplate to build a FindObjects template from the URI. These would better as first-class citizens rather than each application needing to implement them.

@dwmw2
Copy link
Author

dwmw2 commented Jun 19, 2023

Ah, perhaps this is a duplicate of #129

I think better integration of the URI code would be beneficial; having it merely available as a wrapper isn't ideal.

@miekg
Copy link
Owner

miekg commented Jun 21, 2023

looks to me like those functions need to be available in go-pkcs11uri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants