Update Zoom SDK version to resolve app crashing on Android 14 #341
Conversation
android/build.gradle
Outdated
| @@ -36,7 +36,8 @@ android { | |||
| dependencies { | |||
| implementation 'com.facebook.react:react-native:+' // From node_modules | |||
|
|
|||
| implementation 'com.github.zoom-us-community:jitpack-zoom-us:5.16.2.16555' | |||
| // implementation 'com.github.zoom-us-community:jitpack-zoom-us:5.16.2.16555' | |||
| implementation 'com.github.chirag-codealchemy:zoom:5.17.1.18530' | |||
There was a problem hiding this comment.
5.17 is already available in the zoom-us-community jitpack
https://github.com/zoom-us-community/jitpack-zoom-us
android/build.gradle
Outdated
| @@ -78,4 +79,9 @@ dependencies { | |||
| implementation 'io.reactivex.rxjava2:rxandroid:2.1.1' | |||
| implementation 'org.greenrobot:eventbus:3.1.1' | |||
| implementation 'com.davemorrissey.labs:subsampling-scale-image-view:3.10.0' | |||
|
|
|||
| // newly added deps(refer zoom SDK doc) | |||
There was a problem hiding this comment.
No need for the extra comments
|
Thank you for working on this! Just a couple small things I commented on. |
|
Hi! I was just wondering about the status of this PR and if I could provide any support in getting this moved forward |
android/build.gradle
Outdated
| @@ -78,4 +79,9 @@ dependencies { | |||
| implementation 'io.reactivex.rxjava2:rxandroid:2.1.1' | |||
| implementation 'org.greenrobot:eventbus:3.1.1' | |||
| implementation 'com.davemorrissey.labs:subsampling-scale-image-view:3.10.0' | |||
|
|
|||
| // newly added deps(refer zoom SDK doc) | |||
There was a problem hiding this comment.
| // newly added deps(refer zoom SDK doc) |
android/build.gradle
Outdated
| // implementation 'com.github.zoom-us-community:jitpack-zoom-us:5.16.2.16555' | ||
| implementation 'com.github.chirag-codealchemy:zoom:5.17.1.18530' |
There was a problem hiding this comment.
| // implementation 'com.github.zoom-us-community:jitpack-zoom-us:5.16.2.16555' | |
| implementation 'com.github.chirag-codealchemy:zoom:5.17.1.18530' | |
| implementation 'com.github.zoom-us-community:jitpack-zoom-us:5.17.11.20433' |
If you wouldn't mind making/testing the changes I suggested that would be very much appreciated 😄 |
|
Added PR #352 to address this |
There was a problem hiding this comment.
@chirag-codealchemy Apologies, I've already merged #353.
I did not notice that you made these changes first.
Thank you for the contribution and sorry for the delay!
Problem:
The app was experiencing crashes on devices running Android 14 due to compatibility issues with Zoom SDK version 5.16.2.16555. This was causing inconvenience to users and impacting the app's performance.
Solution:
To address this issue, I have updated the Zoom SDK version from 5.16.2.16555 to 5.17.1.18530. This change has resolved the crashes on Android 14 devices, ensuring a smoother user experience.
Rationale:
Although the latest version of the Zoom SDK is available, it was causing crashes when users attempted to join meetings. The error message indicated that the SDK targeting U+ (version 34 and above) disallows certain flags for security reasons. To avoid these crashes, I opted for version 5.17.1.18530, which provides stability without encountering the aforementioned error.
Changes Made:
Updated Zoom SDK version from 5.16.2.16555 to 5.17.1.18530 in the project dependencies.
Testing:
I have thoroughly tested the app on devices running Android 14 to ensure that the crashes no longer occur. Additionally, I have verified that the app functions as expected, including joining meetings without encountering the error mentioned above.
Impact:
This change resolves the crashing issue on Android 14 devices, improving the overall reliability and usability of the app for affected users.
Useful Links:
Zoom Developer Forum - Android 14 Crash Issue
Zoom Developer Forum - Latest Version Crash Issue
Zoom SDK Change Log - Version 5.17.0