Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transferring large files does not seem to work #20

Closed
towai opened this issue Dec 13, 2020 · 5 comments
Closed

Transferring large files does not seem to work #20

towai opened this issue Dec 13, 2020 · 5 comments

Comments

@towai
Copy link

towai commented Dec 13, 2020

i just tried to transfer a 7GB file to my computer via the browser host (from a computer which does not have ezshare installed) and when the upload completed nothing happened. a small image transferred just fine, though. is there a practical or enforced file size limit which is not mentioned in the readme and not checked for before uploading?

@mifi
Copy link
Owner

mifi commented Dec 13, 2020

Hi. There is a max file size of 4GB, but it can be increased with ezshare --max-upload-size.

I will increase the initial max to 16GB for the next version

For more info run ezshare --help

@mifi
Copy link
Owner

mifi commented Dec 13, 2020

I also added an error when this happens

mifi added a commit that referenced this issue Dec 13, 2020
@towai
Copy link
Author

towai commented Dec 14, 2020

Hi. There is a max file size of 4GB, but it can be increased with ezshare --max-upload-size.

I will increase the initial max to 16GB for the next version

For more info run ezshare --help

really, really should've tried --help in the first place. honestly felt a bit of regret after sending this since i knew i didn't really do the diligence i could've (was still in the middle of working out moving that file after all) but yeah, that is good to make clearer (also maybe to make it persist until user closes it since a large upload is probably not being continually monitored and if there was an error message it went away quickly). and i do think increasing the default max filesize is a good idea, since the reason for using this method in the first place was because of the size of the file (didn't have a USB drive laying around with large enough partition).
Thanks

@mifi
Copy link
Owner

mifi commented Dec 14, 2020

No worries. You did find a bug after all! Let me know if it works then we can close this

@towai
Copy link
Author

towai commented Dec 22, 2020

Of course it works, my bad, didn't realise i didn't close this

@towai towai closed this as completed Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants