Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ical.js v1.3.0 breaks a test #11

Closed
mifi opened this issue Aug 12, 2019 · 3 comments
Closed

ical.js v1.3.0 breaks a test #11

mifi opened this issue Aug 12, 2019 · 3 comments

Comments

@mifi
Copy link
Owner

mifi commented Aug 12, 2019 

  1)  should parse issue 285 case correctly:
      AssertionError: [] deepEqual [ '2017-01-18T08:00:00.000Z' ]
      + expected - actual
      -[]
      +[
      +  "2017-01-18T08:00:00.000Z"
      +]
      
      at Context.<anonymous> (test/ical-expander.js:49:10)

See:
mifi added a commit that referenced this issue Aug 12, 2019
@mifi
fix ical.js to prevent broken test #11
ddea76a
@andeee andeee mentioned this issue Jan 22, 2020
Closed
@radarfox
Copy link

This looks like a duplicate of #14

@mifi
Copy link
Owner Author

mifi commented Apr 24, 2020

I think this one should be fixed now

@radarfox
Copy link

radarfox commented Apr 26, 2020 •
edited
Loading

Yes it should, version 3 works for me in similar tests.

@mifi mifi closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mifi @radarfox