Skip to content

Commit

Permalink
upgrade ffmpeg #231
Browse files Browse the repository at this point in the history
  • Loading branch information
@mifi
mifi committed Feb 11, 2020
1 parent 8a7935f commit 9eb8f9e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"electron-default-menu": "^1.0.0",
"electron-is-dev": "^0.1.2",
"execa": "^0.5.0",
"ffmpeg-static": "^2.7.0",
"ffmpeg-static": "3",
"ffprobe-static": "^3.0.0",
"file-type": "^12.4.0",
"github-api": "^3.2.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2350,10 +2350,10 @@ fd-slicer@~1.0.1:
dependencies:
pend "~1.2.0"

ffmpeg-static@^2.7.0:
version "2.7.0"
resolved "https://registry.yarnpkg.com/ffmpeg-static/-/ffmpeg-static-2.7.0.tgz#e1b050f7c0457595fceccec7d8bb04cdb8f223dc"
integrity sha512-Khjg/4tCBen58ixhXlkRNqs3hUKpTOlGOUrw859M09tdjeMkXyXRQ+YuJjGczRhGO7Y8fHPJZcQ37V/OzvZvjQ==
ffmpeg-static@3:
version "3.0.0"
resolved "https://registry.yarnpkg.com/ffmpeg-static/-/ffmpeg-static-3.0.0.tgz#e5d259023682f118ea370eab937385c8da4c664f"
integrity sha512-LCBAB1J10ku7+SWbFTLJ4zjDtrniwYDMIyRmg1Vxvzst5TyCrsrfKHg1YPrvvsUhrzknTXxL6NoUG6s2xftbcg==

ffprobe-static@^3.0.0:
version "3.0.0"
Expand Down

4 comments on commit 9eb8f9e

@opusforlife2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. What is the reason for using this version of ffmpeg and not the latest?

@mifi
Copy link
Owner Author

@mifi mifi commented on 9eb8f9e Feb 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a breaking change in newest ffmpeg static that breaks electron. See eugeneware/ffmpeg-static#35

@opusforlife2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that newer versions of ffmpeg can't be used with lossless-cut at all? Or just that you can't ship them with the application by default?

And anyway, does the version of ffmpeg affect the functionality?

@mifi
Copy link
Owner Author

@mifi mifi commented on 9eb8f9e Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ffmpeg is always improving so it may affect the functionality. Right now we are stuck on the non-newest version of ffmpeg, but if upstream finds a solution for the electron, we will be able to upgrade. If not then maybe i fork the ffmpeg-static repo to make an electron compat variant

Please sign in to comment.