Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw issue on timeline around playhead #259

Closed
dngrlux opened this issue Feb 26, 2020 · 8 comments
Closed

Redraw issue on timeline around playhead #259

dngrlux opened this issue Feb 26, 2020 · 8 comments

Comments

@dngrlux
Copy link

dngrlux commented Feb 26, 2020

I'm noticing a redraw issue in the latest builds. Vertical black bars are appearing around the playhead.

I believe it started somewhere around version 3.8.0, and has not been resolved as of 3.9.1. [macOS Catalina 10.15.3]

redraw screenshot

@mifi
Copy link
Owner

mifi commented Feb 26, 2020

Did you do something to these screenshots? I added black 1px wide bars to indicate keyframes, but they look more like this:

Screenshot 2020-02-26 at 10 54 13

If no, how do you reproduce this issue?

@dngrlux
Copy link
Author

dngrlux commented Feb 26, 2020

Those screenshots were only cropped. I just downloaded 3.10.0 and there are still redraw oddities, although different than before (screen recording attached). I am dragging a video into the application window, then using the i and o hotkeys to mark in and out points.

Screen Recording 2020-02-26.zip

@mifi
Copy link
Owner

mifi commented Feb 27, 2020

Interesting! Thanks for sharing screenrec. I think the issue here is that your video has a LOT of keyframes, and they are all being rendered due to the new feature I added of rendering keyframes. I will make a button to toggle showing of keyframes.
What kind of video format is this?

mifi added a commit that referenced this issue Feb 27, 2020
@EtiamNullam
Copy link

For me black square covering the timeline was following the cursor.
LosslessCut 3.8.0, Windows 10

0VTgOQBtvW

Update to LosslessCut 3.11.0 fixed the problem.

@mifi
Copy link
Owner

mifi commented Feb 28, 2020

What kind of file is this @EtiamNullam ? Do you mind to share a short segment from one file? I think this is also caused by keyframes very tightly packed together

@dngrlux
Copy link
Author

dngrlux commented Feb 28, 2020

That sounds right… if I zoom into the timeline, they start to spread out.
The video is from a Skydio 2 drone. MP4, H.264 HD (1-1-1), 3840x2160, 60fps, 100mbit/sec.

@EtiamNullam
Copy link

@mifi: Yes I think you're right. I don't have the previous file anymore but I have encountered similar behavior with different file (using LosslessCut 3.11.0).

image

It's a recording of game using Nvidia Experience (Geforce Share). Codec info:

image

Hiding keyframes helps, so I guess they were indeed just tightly packed.

@mifi
Copy link
Owner

mifi commented Mar 4, 2020

I want to make it more clear that they are keyframes or hide them altogether when too tightly packed to be useful

@mifi mifi closed this as completed in 209c1b1 Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants