Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external ffmpeg/ffprobe #400

Closed
soloturn opened this issue Jun 7, 2020 · 5 comments
Closed

Use external ffmpeg/ffprobe #400

soloturn opened this issue Jun 7, 2020 · 5 comments

Comments

@soloturn
Copy link

soloturn commented Jun 7, 2020

how could one build / package lossless-cut so operating system installed binaries like ffmpeg, ffprobe will be used?

@mifi
Copy link
Owner

mifi commented Jul 9, 2020

There was a discussion about this in #108

What is the reason for needing to use system installed ffmpeg?

@soloturn
Copy link
Author

soloturn commented Jul 13, 2020

arch linux can install newest electron, ffmpeg. losslesscut then would not take 337MB as it does now, and ship an outdated ffmpeg. there is hints how to deal with electron applications: https://wiki.archlinux.org/index.php/Electron_package_guidelines .

in linux packaging, in general, one specifies the dependencies, and they get installed. just like you do in your javascript app. you specify the depencency and not copy the code into your application. the location is standardized for all distributions with the https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard:

$ which ffmpeg
/usr/bin/ffmpeg
$ which ffprobe
/usr/bin/ffprobe

@mifi
Copy link
Owner

mifi commented Jul 13, 2020

In order to achieve this we would need to:

  1. Make a separate build that excludes the binaries from the bundle
  2. Make the ffmpeg/ffprobe executing code fallback to system ffmpeg when not found internally

@mifi mifi mentioned this issue Mar 31, 2021
21 tasks
@mifi mifi changed the title how to package losslesscut to use operating system installed binaries Use external ffmpeg/ffprobe Feb 24, 2022
mifi added a commit that referenced this issue Mar 1, 2022
@mifi
Copy link
Owner

mifi commented Mar 1, 2022

have now added support for selecting a custom ffmpeg/ffprobe path in settings

@mifi
Copy link
Owner

mifi commented Mar 17, 2022

I think I will close this, because now it's possible to select operating system ffmpeg/ffprobe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants