Process all frames on the stack even if some error out. Added option… #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PURPOSE OF MODIFICATION:
There was a frame in the middle of my stack that BasicSourceMapConsumer.originalPositionFor was erroring out on (no line# in this case), but I had more frames in the stack that I was curious if BasicSourceMapConsumer.originalPositionFor could get positions for. It can in my cases. Unfortunately, I can't provide the map to proprietary code to help with this example, but I think the code makes sense. There are other options that could of been implemented for this specific example, but I like the idea of processing the next frame regardless of what error the consumer comes up with for the current frame.
EXAMPLE STACK:
TypeError: Cannot read property 'IsCompleteFlag' of undefined
at Module.p(x.js:1:2789898)
at ? (x.js:1:746448)
at Array.forEach()
at Ci(x.js:1:746410)
at ? (x.js:1:746256)
at ? (x.js:1:742338)
at Object.next(x.js:1:742443)
at o(x.js:1:741211)
ORIGINAL OUTPUT:
Stops at at Array.forEach().
MODIFIED OUTPUT:
Keeps going past at Array.forEach() (or anything else that might error out).
CAN STILL GET ORIGINAL OUTPUT WITH OPTION: