Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path issues on windows #20

Merged
merged 3 commits into from
Dec 23, 2023
Merged

fix path issues on windows #20

merged 3 commits into from
Dec 23, 2023

Conversation

Lunarequest
Copy link
Contributor

this should fix #19

@Lunarequest
Copy link
Contributor Author

@mighdoll would you mind reviewing this?

@mighdoll
Copy link
Owner

will do

@mighdoll mighdoll merged commit 0566aa2 into mighdoll:master Dec 23, 2023
@SimonSimCity
Copy link
Contributor

Could you please check this code again? I've tried to use it, but it didn't fix the problem.

When running the following code in node

const { platform } = require('os');
console.log(platform.name)

I receive text platform on my console.

When digging a bit deeper, I found out, that os.platform is a function (https://nodejs.org/api/os.html#osplatform). Alternatively, process.platform could be used, which is a property (https://nodejs.org/api/process.html#processplatform).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultOutDir produces invalid path on Windows
3 participants