Seal coercible (for safety), make it not subclass Function1 (to preve…

…nt accidentally putting implicit conversions in scope)
mighdoll · Mar 24, 2010 · bc31c5b · bc31c5b
1 parent 7009bea
commit bc31c5b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/main/scala/scalaj/collection/j2s/Implicits.scala b/src/main/scala/scalaj/collection/j2s/Implicits.scala
@@ -20,7 +20,9 @@ trait Implicits {
   implicit def RichJDictionary[A, B](underlying: ju.Dictionary[A, B]): RichDictionary[A, B] = new RichDictionary(underlying)
 }
 
-trait Coercible[A, B] extends (A => B)
+sealed trait Coercible[-A, +B] {
+  def apply(x: A): B
+}
 
 object Coercible extends LowPriorityCoercible {
   private[collection] def coerce[M[_], A, B](m: M[A])(implicit c: Coercible[A, B]): M[B] = m.asInstanceOf[M[B]]

diff --git a/src/main/scala/scalaj/collection/s2j/Implicits.scala b/src/main/scala/scalaj/collection/s2j/Implicits.scala
@@ -22,7 +22,9 @@ trait Implicits {
   implicit def RichSMutableMap[A, B](underlying: scm.Map[A, B]): RichMutableMap[A, B] = new RichMutableMap(underlying)
 }
 
-trait Coercible[A, B] extends (A => B)
+sealed trait Coercible[-A, +B] {
+  def apply(x: A): B
+}
 
 object Coercible extends LowPriorityCoercible {
   private[collection] def coerce[M[_], A, B](m: M[A])(implicit c: Coercible[A, B]): M[B] = m.asInstanceOf[M[B]]