Use c3 linearization in the MOP #1033

fare · 2023-10-31T12:57:01Z

Runtime improvements

MOP:

Use c3 linearization for class precedence list.
Implement and use the C3 linearization algorithm for multiple inheritance.
Unify struct fields and class slots, using struct inheritance then class precedence list for slot order. This improves on previous semantics, but introduces a slight incompatibility and will require updating the optimizer.
Accordingly update various modules in std.

Also:

Define defmutable in prelude.
Add a (dump-backtrace?) parameter to control backtrace printing.
Support build-manifest in the runtime.
Move DBG macro in the runtime for past and future debugging.

Regenerate bootstrap.

netlify · 2023-10-31T12:57:07Z

✅ Deploy Preview for elastic-ritchie-8f47f9 ready!

Name	Link
🔨 Latest commit	`43f6781`
🔍 Latest deploy log	https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/65b878d710dc500008b5a344
😎 Deploy Preview	https://deploy-preview-1033--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fare · 2023-10-31T12:57:22Z

Builds upon the cli branch of #1027.

vyzo

Generally looks good, but can you please avoid the internal splicing defs as it makes the code slower?

Also, can you optimize a tad the intermediate garbage lists?
I suspect the code is about twice as slow as it could be.

I will add the slicing let form for v0.19 so that we don't have this problem in the future.

doc/reference/std/misc/rtd.md

src/gerbil/prelude/core.ss

src/gerbil/runtime/c3.ss

src/gerbil/runtime/error.ss

src/gerbil/runtime/mop.ss

src/gerbil/runtime/system.ss

fare · 2023-11-04T23:21:37Z

PTAL

vyzo

looks mostly good, some cosmetic comments.

src/gerbil/runtime/c3.ss

src/gerbil/runtime/error.ss

src/gerbil/runtime/mop.ss

fare · 2023-11-08T00:38:48Z

PTAL

src/gerbil/runtime/c3.ss

src/gerbil/runtime/mop.ss

fare · 2024-01-07T04:45:00Z

PTAL

doc/reference/gerbil/runtime/MOP.md

doc/reference/std/errors.md

vyzo

Some more comments for using the low level fx ops, we know they are fixnum and we don't need the type checks there.

Other than that, I think we should rename the plist/alist thing to properties.

But let's move this forward, the rename can happen in the next step to alleviate some pain.

src/gerbil/runtime/c3.ss

src/gerbil/runtime/mop.ss

fare · 2024-01-08T16:07:39Z

PTAL

vyzo

there are a few unrelated things, maybe we should pick them up for separate prs.

doc/reference/std/errors.md

doc/reference/std/misc/rtd.md

src/gerbil/runtime/c3.ss

src/gerbil/runtime/mop.ss

src/std/debug/DBG.ss

vyzo

can we resolve the open threads?

doc/reference/std/errors.md

Use c3 linearization for the class precedence list. Use the class precedence list for the slot index allocation. Test and document it all. Define defmutable in prelude. Add a (dump-backtrace?) parameter to control backtrace printing. Support build-manifest in the runtime. Distinguish cases of "Bad syntax". Regenerate the runtime bootstrap. std/misc/rtd: add type=? Integrate feedback from review. Fix c3-test for destructive operations More review feedback Checkpointing progress with MOP refactoring

vyzo

Well ok, let's merge it and follow up.

I left a big pile of comments for the follow up(s).

vyzo · 2024-01-29T16:20:59Z

doc/reference/dev/bootstrap.md

+- The solution is to create a *new* API with *new* names that
+  must absolutely not clash with the old names.
+  Add a suffix or prefix such as `*`, `/2` or `%`, or take the opportunity
+  to give functions better, longer and/or more systematic names.


let's drop the "longer" :)

vyzo · 2024-01-29T16:23:23Z

doc/reference/std/errors.md

+
+This parameter is notably used by the `display-exception` method for
+the `Error` type in the runtime, and by `with-exception-stack-trace`
+(see above) that is also used in the default exceptio handler installed


vyzo · 2024-01-29T16:25:45Z

src/build/build-bach.ss

@@ -27,6 +27,7 @@
    "gerbil/runtime/system"
    "gerbil/runtime/loader"
    "gerbil/runtime/control"
+    "gerbil/runtime/c3"


I think we should collect those in a separate text file for inclusion, I hate myself for having 3 different versions of this list; can happen in a subsequent pr.

vyzo · 2024-01-29T16:27:41Z

src/gerbil/prelude/core.ss

+    ;; c3 linearization
+    c3-linearize not-null? remove-nulls append-reverse


we'll need to groups those better, c3-linearize goes with the mp, the other two are general utilities.

vyzo · 2024-01-29T16:28:47Z

src/gerbil/prelude/core.ss

-        (def (class-opt? key)
-          (memq (stx-e key) '(slots: id: name: plist: constructor: unchecked:)))
+       (def (class-opt? key)
+          (memq (stx-e key) '(slots: id: name: alist: constructor: unchecked:)))


these should become properties:, but we can do in follow up.

vyzo · 2024-01-29T16:56:12Z

src/gerbil/runtime/mop.ss

+;; In exchange for which 3. it's somewhat simpler and slightly faster in
+;; the usual case that doesn't involve a call to next-method.


probably quite a bit more than slightly :)

vyzo · 2024-01-29T16:56:34Z

src/gerbil/runtime/mop.ss

+;; Changing the protocol to access an explicit super argument would be
+;; semantically nicer and would enable linear complexity for next-method
+;; (in the number of classes, or even just in the number of applicable method,
+;; if resolved only once), but would be notably more complex and somewhat
+;; incompatible (or involve much cleverness for backward compatibility).


this comment is quite misleading i think, do we need it?

Basically there is a tradeoff: either you have faster and simpler/leaner code for 99% of the cases, and let 1% have a quadratic which is usually small, or make verything slower/more bloated for that 1%....

f*ck the 1%! occupy LiSP! :)

vyzo · 2024-01-29T16:59:13Z

src/gerbil/runtime/system.ss

+(defrules defmutable ()
+  ((_ var value) (begin (def var value) (set! var var) (void))))
+
+(def gerbil-system-manifest


this ends up being completely unrelated and maybe we should pull it to a separate pr... oh well, probably too much work and pain.

src/gerbil/runtime/util.ss

vyzo changed the base branch from master to cli October 31, 2023 14:24

fare force-pushed the cli branch from 89e81f0 to 8012903 Compare October 31, 2023 19:59

fare force-pushed the gxpkg-c3 branch 4 times, most recently from dc2d52e to b81f43a Compare October 31, 2023 23:51

fare changed the title ~~[WIP] Use c3 in defclass, gxpkg~~ [WIP] Better graph traversal in defclass, gxpkg Nov 1, 2023

fare force-pushed the gxpkg-c3 branch 2 times, most recently from 54b9b04 to 08e591d Compare November 1, 2023 21:25

fare changed the title ~~[WIP] Better graph traversal in defclass, gxpkg~~ Use c3 linearization in defclass, and more Nov 1, 2023

fare force-pushed the gxpkg-c3 branch from 537c78f to 3640a54 Compare November 1, 2023 22:38

fare force-pushed the cli branch from 8012903 to ee12990 Compare November 3, 2023 07:03

fare force-pushed the gxpkg-c3 branch from 3640a54 to 6cef037 Compare November 3, 2023 07:04

fare changed the base branch from cli to bad-syntax November 3, 2023 22:27

fare force-pushed the gxpkg-c3 branch from 6cef037 to 86a4e9f Compare November 3, 2023 22:28

fare changed the base branch from bad-syntax to master November 3, 2023 22:45

fare changed the base branch from master to string November 4, 2023 06:37

Base automatically changed from string to master November 4, 2023 07:06

fare force-pushed the gxpkg-c3 branch from 2e2ae56 to 7332d57 Compare November 4, 2023 07:28

vyzo reviewed Nov 4, 2023

View reviewed changes

fare enabled auto-merge (squash) November 4, 2023 11:01

vyzo reviewed Nov 7, 2023

View reviewed changes

fare force-pushed the gxpkg-c3 branch 2 times, most recently from 96cde9f to 65e6169 Compare November 8, 2023 00:38

vyzo reviewed Nov 8, 2023

View reviewed changes

src/gerbil/runtime/c3.ss Outdated Show resolved Hide resolved

src/gerbil/runtime/mop.ss Outdated Show resolved Hide resolved

src/gerbil/runtime/mop.ss Outdated Show resolved Hide resolved

fare force-pushed the gxpkg-c3 branch from 65e6169 to d84890a Compare November 13, 2023 20:52

vyzo reviewed Jan 8, 2024

View reviewed changes

doc/reference/gerbil/runtime/MOP.md Outdated Show resolved Hide resolved

doc/reference/std/errors.md Outdated Show resolved Hide resolved

vyzo reviewed Jan 8, 2024

View reviewed changes

fare force-pushed the gxpkg-c3 branch from 80544ac to adca0cf Compare January 8, 2024 16:07

vyzo reviewed Jan 16, 2024

View reviewed changes

fare force-pushed the gxpkg-c3 branch from 5747fdb to 81179e8 Compare January 20, 2024 02:05

vyzo reviewed Jan 21, 2024

View reviewed changes

doc/reference/std/errors.md Outdated Show resolved Hide resolved

fare force-pushed the gxpkg-c3 branch from 161cc45 to 84f52de Compare January 22, 2024 18:16

fare added 8 commits January 23, 2024 15:04

Fixes post review

466ce29

More review fixes

483458c

More fixes after review

cd385b3

Fix issues with -alist to -properties renaming

b90195d

Doc tweaks

72be53a

Another cleanup pass

89c0c29

Fix c3-test

261feff

fare force-pushed the gxpkg-c3 branch from b8c2fbf to 261feff Compare January 23, 2024 20:05

fare mentioned this pull request Jan 23, 2024

Update struct / class macros #1111

Closed

vyzo approved these changes Jan 29, 2024

View reviewed changes

Last pass

5a7bf7b

vyzo changed the title ~~Use c3 linearization in defclass, and more~~ Use c3 linearization in the MOP Jan 29, 2024

fare added 5 commits January 29, 2024 20:44

Remove a comment

de34a8c

protobuf/macros: alist => properties

28d5a26

Yet another pass from review

69cd461

Fix bug in previous refactoring of struct-field-offset*

9b267b1

Remove commented-out debugging lines

43f6781

fare enabled auto-merge (squash) January 30, 2024 04:23

fare merged commit c47bc90 into master Jan 30, 2024
12 checks passed

fare deleted the gxpkg-c3 branch January 30, 2024 04:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use c3 linearization in the MOP #1033

Use c3 linearization in the MOP #1033

fare commented Oct 31, 2023 •

edited

Loading

netlify bot commented Oct 31, 2023 •

edited

Loading

fare commented Oct 31, 2023 •

edited

Loading

vyzo left a comment

fare commented Nov 4, 2023

vyzo left a comment

fare commented Nov 8, 2023

fare commented Jan 7, 2024

vyzo left a comment

fare commented Jan 8, 2024

vyzo left a comment

vyzo left a comment

vyzo left a comment

vyzo Jan 29, 2024

vyzo Jan 29, 2024

vyzo Jan 29, 2024

vyzo Jan 29, 2024

vyzo Jan 29, 2024

vyzo Jan 29, 2024

vyzo Jan 29, 2024

vyzo Jan 29, 2024

vyzo Jan 29, 2024

		;; c3 linearization
		c3-linearize not-null? remove-nulls append-reverse

		;; In exchange for which 3. it's somewhat simpler and slightly faster in
		;; the usual case that doesn't involve a call to next-method.

Use c3 linearization in the MOP #1033

Use c3 linearization in the MOP #1033

Conversation

fare commented Oct 31, 2023 • edited Loading

netlify bot commented Oct 31, 2023 • edited Loading

✅ Deploy Preview for elastic-ritchie-8f47f9 ready!

fare commented Oct 31, 2023 • edited Loading

vyzo left a comment

Choose a reason for hiding this comment

fare commented Nov 4, 2023

vyzo left a comment

Choose a reason for hiding this comment

fare commented Nov 8, 2023

fare commented Jan 7, 2024

vyzo left a comment

Choose a reason for hiding this comment

fare commented Jan 8, 2024

vyzo left a comment

Choose a reason for hiding this comment

vyzo left a comment

Choose a reason for hiding this comment

vyzo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fare commented Oct 31, 2023 •

edited

Loading

netlify bot commented Oct 31, 2023 •

edited

Loading

fare commented Oct 31, 2023 •

edited

Loading