Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support merging generic related fields #32

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

mumumumu
Copy link
Contributor

@mumumumu mumumumu commented May 22, 2020

Had to dig into the Django generic foreign relation internals to figure out how to pull out the name of the related generic foreign key field.

Closes #5
Closes #6

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #32 into master will increase coverage by 2.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   96.26%   99.10%   +2.84%     
==========================================
  Files           7        1       -6     
  Lines         375      112     -263     
  Branches       24       19       -5     
==========================================
- Hits          361      111     -250     
+ Misses         13        0      -13     
  Partials        1        1              
Impacted Files Coverage Δ
django_super_deduper/merge.py 99.10% <100.00%> (+0.05%) ⬆️
setup.py
tests/factories.py
django_super_deduper/models.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ba7a4...56e468a. Read the comment docs.

@mumumumu mumumumu merged commit a4770df into master May 26, 2020
@mumumumu mumumumu deleted the generic-foreign-keys branch May 26, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't handle GenericRelation
2 participants