Allow Guarded containers to be ReactNode, not only ComponentClass #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbouchard
commented
Apr 1, 2019
| isGuarded: boolean; | ||
| } | ||
|
|
||
| export function createDisabledContainer (WrappedComponent: React.ComponentClass<any>): React.ComponentClass { | ||
| export function createDisabledContainer (WrappedComponent: React.ComponentType<any>): React.ReactNode { |
There was a problem hiding this comment.
WrappedComponent: React.ReactNode here wouldn't work, it would trigger issues w/ constructor call signature.
kbouchard
commented
Apr 1, 2019
| @@ -45,7 +45,7 @@ export function createDisabledContainer (WrappedComponent: React.ComponentClass< | |||
| export function createGuardedContainer ({ isGuarded, enabledComponent, disabledComponent }: IGuardedContainerProps): React.ComponentClass { | |||
| @observer | |||
| class GuardedContainer extends Component { | |||
| private readonly GuardedComponent: React.ComponentClass; | |||
| private readonly GuardedComponent: any; | |||
There was a problem hiding this comment.
I know this isn't optimal, but I spend a lot of time trying to figure that one out.
The issue is that we're setting that value after the constructor has triggered, so it would technically need to be :
private readonly GuardedComponent: React.ComponentClass<any> | {} | null | undefined;
Which felt ... messy || not efficient enough to justify it ?
Let me know what you think.
rkuykendall
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this restriction:
