Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display value when last-4-digits passed to formatSocialSecurityNumber #247

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

rkuykendall
Copy link
Contributor

@rkuykendall rkuykendall commented Mar 5, 2020

@@ -11,13 +11,13 @@ script: echo "Running tests against $(node -v)..." && yarn test
jobs:
include:
- stage: Build
node_js: node
node_js: 10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 Necessary since we're so behind on libraries

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkuykendall why? what changed in this PR that makes this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in this PR. The change was node steadily advancing while we're stuck in the past. So I had to lock our build step to node 10 to fix builds again, until we do the update.

@rkuykendall rkuykendall merged commit d7d252b into master Mar 5, 2020
@rkuykendall rkuykendall deleted the ssn branch March 5, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants