Improve function types and bump libraries #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rkuykendall
commented
Jan 11, 2022
•
rkuykendall
commented
rkuykendall
commented
Jan 11, 2022
| if (isString(value)) { | ||
| return value.trim(); | ||
| if (isNumber(value)) { | ||
| return String(value); |
There was a problem hiding this comment.
This is the only functional change here, and it's reflected in the test suite.
There was a problem hiding this comment.
was this change necessary for the ant design upgrade?
There was a problem hiding this comment.
Nope. Just seemed like a good change. getOrDefault should probably return a string, right? If not, I can change it to string | number
There was a problem hiding this comment.
I would leave it as string | number, since I see this function as defaulting only if the value is empty. but don't feel strongly either way. doesn't look like it's being used for numbers currently.
ekatsuta
approved these changes
Jan 11, 2022
| if (isString(value)) { | ||
| return value.trim(); | ||
| if (isNumber(value)) { | ||
| return String(value); |
There was a problem hiding this comment.
was this change necessary for the ant design upgrade?
ekatsuta
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.