Add warning to nextcloud_apps.py #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mightyBroccoli
requested changes
Nov 16, 2018
|
I have to say that I did this to my local installation too. But I was not really sure what to set the warning level/ amount to. |
Co-Authored-By: alejandroscf <alejandroscf@gmail.com>
|
The moment you have an update available, you may have a security issue until you update that app, so I think that always rising a warning is a good move. |
|
I think that your approach is better then mine. If there people start to complain with a reason the change could be done. |
mightyBroccoli
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the 'update available' warning to the non-multigraph plugin.