major rework #6
Merged
major rework #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mightyBroccoli
commented
Nov 7, 2018
mightyBroccoli
commented
- updated gitignore file
- partly reworked servercontact implementation
- complete rework of uptime, version
- part rework of xep requests
- added more comments to xep requests
- added opt_arg to version, xep and contact
- complete rework of validate function
- updated HandleError function
- part rework of StaticStrings function
- implemented data dictionary to hold all data in main bot
- added message_ids
- complete rework of queue building and deduplication
* leading 0 fix * validation function improvements * moved strings.py and misc files to /common/
- removed asyncio from import * fixed bug with muc jid parser * outsorced validate and dedup to misc.py
* updated gitignore file * partly reworked servercontact implementation * complete rework of uptime, version * part rework of xep requests + added more comments to xep requests + added opt_arg to version, xep and contact * complete rework of validate function * updated HandleError function * part rework of StaticStrings function + implemented data dictionary to hold all data in main bot + added message_ids * complete rework of queue building and deduplication
* corrected logging.INFO to .info * small changes to HandleError class
+ added timestamp to logging output * finished up HandleError output
* +x to main.py + added catch for a None response as some xeps have addition tags some do not have
* fixed NoneType tag bug
- remove unused variable * better iteration of xdata nodes - removed unnecessary else
* reduced amount of unnecessary elif after return * some formatting
Repository owner
deleted a comment
Nov 9, 2018
+ added opt_arg abbreviation
* fix loglevel be set to the correct logging parameter
ravermeister
added a commit
to ravermeister/xmpp-chatbot
that referenced
this pull request
Jan 26, 2022
Privmsg Closes mightyBroccoli#6 See merge request xmpp/xmpp-chatbot!3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.