Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new rule @typescript-eslint/return-await always #253

Merged
merged 1 commit into from
Mar 17, 2020
Merged

feat: new rule @typescript-eslint/return-await always #253

merged 1 commit into from
Mar 17, 2020

Conversation

mightyiam
Copy link
Owner

BREAKING CHANGE: new rule @typescript-eslint/return-await always

Closes #199.

@mightyiam
feat: new rule @typescript-eslint/return-await always
216e63b 
BREAKING CHANGE: new rule @typescript-eslint/return-await always

Closes #199.
LinusU
LinusU approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is the best approach 👍

@mightyiam mightyiam merged commit 8b4acc7 into master Mar 17, 2020
@mightyiam mightyiam deleted the return-await-always branch March 17, 2020 12:36
@LinusU LinusU mentioned this pull request Mar 17, 2020
Merged
@toddbluhm
Copy link
Contributor

I know I am a bit late to the party, but I agree with @LinusU on this. I do think return await improves readability a lot and the additional frame in the stack trace is very useful. The performance costs seem to be negligible (and may even be non-existent in production builds/transpiling for typescript).

@mightyiam
Copy link
Owner Author

@toddbluhm late feedback also helps 😄 thank you.

@KilianKilmister
Copy link

Some even later feedback: #417

@Yshayy Yshayy mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Considering return-await rule
4 participants
@mightyiam @toddbluhm @KilianKilmister @LinusU