maintenance #602
Merged
maintenance #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mightyiam
commented
Jul 2, 2021
mightyiam
commented
- test(deps): log dep in peer dep inclusion test
- fix(deps): expand eslint-plugin-promise peerDep to equal upstream
- fix(deps): sort peer deps
- chore(deps): update some dev deps
mightyiam
commented
Jul 2, 2021
| t.is(ourDep, standardDep) | ||
| t.is(ourDep, standardDep, name) |
There was a problem hiding this comment.
This shows us which peer dep is not in alignment with upstream.
package.json
Outdated
| "eslint-plugin-promise": "^4.2.1", | ||
| "eslint-plugin-promise": "^4.2.1 || ^5.0.0", |
There was a problem hiding this comment.
This aligns with upstream.
package.json
Outdated
Comment on lines
62
to
67
| "@typescript-eslint/eslint-plugin": "^4.0.1", | ||
| "eslint": "^7.12.1", | ||
| "eslint-plugin-import": "^2.22.1", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-promise": "^4.2.1 || ^5.0.0", | ||
| "typescript": "^3.9", | ||
| "@typescript-eslint/eslint-plugin": "^4.0.1" | ||
| "typescript": "^3.9" |
There was a problem hiding this comment.
I noticed that npm sorted this for me when I used npm install so I gave the sorting its own commit.
| "@types/node": "14.17.3", | ||
| "@types/node": "15.14.0", |
There was a problem hiding this comment.
I'm not sure how versioning for this works but as long as type checking works we're good, I guess.
| "eslint-plugin-import": "2.23.4", | ||
| "eslint-plugin-node": "11.1.0", | ||
| "eslint-plugin-promise": "4.3.1", | ||
| "husky": "6.0.0", | ||
| "eslint-plugin-promise": "5.1.0", |
There was a problem hiding this comment.
Changelog isn't helpful in figuring out what the breaking change is. But we're not using it directly, buy via upstream, so OK I guess.
| "eslint-plugin-promise": "4.3.1", | ||
| "husky": "6.0.0", | ||
| "eslint-plugin-promise": "5.1.0", | ||
| "husky": "7.0.0", |
There was a problem hiding this comment.
Breaking change is merely dropping unsupported Node.js version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.