Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fortinet.api method more generic #194 #195

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Make fortinet.api method more generic #194 #195

merged 5 commits into from
Feb 26, 2024

Conversation

patrikspiess
Copy link
Member

closes #194

lucmurer
lucmurer requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@lucmurer lucmurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Some small detail changes remaining.

fotoobo/fortinet/fortinet.py Outdated Show resolved Hide resolved
fotoobo/fortinet/fortinet.py Outdated Show resolved Hide resolved
fotoobo/fortinet/fortinet.py Outdated Show resolved Hide resolved
@lucmurer lucmurer merged commit 8702b55 into migros:main Feb 26, 2024
5 checks passed
@patrikspiess patrikspiess deleted the Make-fortinet.api-method-more-generic-#194 branch April 3, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucmurer lucmurer lucmurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make fortinet.api method more generic
2 participants
@patrikspiess @lucmurer