Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to set default hook-runner image #354

Merged
merged 1 commit into from
May 22, 2020

Conversation

jmontleon
Copy link
Collaborator

For each of the following check the box when you have verified either:

  • the changes have been made for each applicable version
  • no changes are required for the item
  • PR's that are submitted without running through the list below will be CLOSED

Affected versions:

  • Latest
  • 1.2
  • 1.1

The CSV is responsible in OLM installs for

  • Operator permissions
  • Operator deployment
  • Operand permissions
  • CRDs

The operator.yml is responsible in non-OLM installs for

  • Operator permissions
  • Operator deployment

The ansible role is responsible in non-OLM installs for:

  • Operand permissions
  • CRDs

The ansible role is always responsible for:

  • Operand deployment

If this PR updates a release or replaces channel

  • I created a new z release directory in deploy/olm-catalog/konveyor-operator
  • I updated channels in the konveyor-operator.package.yaml
  • I created a new release directory in deploy/non-olm
  • I created or updated the major.minor link in deploy/non-olm
  • Updated the .github/pull_request_template.md Affected versions list

@jmontleon jmontleon requested a review from eriknelson May 22, 2020 18:05
@jmontleon jmontleon self-assigned this May 22, 2020
@jmontleon jmontleon force-pushed the set-default-hook-runner-image branch from 27fe964 to db0783e Compare May 22, 2020 18:11
@eriknelson
Copy link
Contributor

Corresponding UI PR that reads the value from the configmap for the default: migtools/mig-ui#877

I've tested this PR's integration with the UI PR and confirmed it's functionality.

@jmontleon jmontleon merged commit 12e6705 into migtools:master May 22, 2020
jmontleon added a commit that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants