Add dns name verify to hook SA name/ns (#876)

migtools · May 22, 2020 · 83fb7b5 · 83fb7b5
1 parent d8cf3c8
commit 83fb7b5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/app/plan/components/Wizard/HooksFormContainer.tsx b/src/app/plan/components/Wizard/HooksFormContainer.tsx
@@ -75,20 +75,28 @@ const AddEditHooksFormContainer = withFormik<
     if (values.clusterType === 'source') {
       if (!values.srcServiceAccountName) {
         errors.srcServiceAccountName = 'Required';
+      } else if (!utils.testDNS1123(values.srcServiceAccountName)) {
+        errors.srcServiceAccountName = utils.DNS1123Error(values.srcServiceAccountName);
       }
 
       if (!values.srcServiceAccountNamespace) {
         errors.srcServiceAccountNamespace = 'Required';
+      } else if (!utils.testDNS1123(values.srcServiceAccountNamespace)) {
+        errors.srcServiceAccountNamespace = utils.DNS1123Error(values.srcServiceAccountNamespace);
       }
     }
 
     if (values.clusterType === 'destination') {
       if (!values.destServiceAccountName) {
         errors.destServiceAccountName = 'Required';
+      } else if (!utils.testDNS1123(values.destServiceAccountName)) {
+        errors.destServiceAccountName = utils.DNS1123Error(values.destServiceAccountName);
       }
 
       if (!values.destServiceAccountNamespace) {
         errors.destServiceAccountNamespace = 'Required';
+      } else if (!utils.testDNS1123(values.destServiceAccountNamespace)) {
+        errors.destServiceAccountNamespace = utils.DNS1123Error(values.destServiceAccountNamespace);
       }
     }
 

diff --git a/src/app/plan/components/Wizard/HooksStep.tsx b/src/app/plan/components/Wizard/HooksStep.tsx
@@ -13,20 +13,12 @@ import {
   Bullseye,
   EmptyState,
   EmptyStateVariant,
-  EmptyStateBody,
   Title,
   Button,
   EmptyStateIcon,
-  InputGroup,
-  TextInput,
-  Flex,
-  FlexItem,
-  FlexModifiers,
 } from '@patternfly/react-core';
-import { SearchIcon } from '@patternfly/react-icons';
 import { AddEditMode } from '../../../common/add_edit_state';
 import HooksFormContainer from './HooksFormContainer';
-import { max } from 'moment';
 import { IMigHook } from '../../../../client/resources/conversions';
 
 const classNames = require('classnames');