New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VolumesForm: Replace Bullseye with Modal to handle critical errors #905
Conversation
@vconzola, please let me know if that's what you'd expect. |
If I'm reading this code right, when the user clicks the "close" button on that modal it will just leave them with an empty wizard step, right? Maybe we want that button to say "Back" and move the wizard back a step when the modal closes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gildub No this isn't what I had in mind. Let me create a mockup tomorrow.
@gildub The wording might not be exactly right, but this is what we want this sort of message to look like. https://drive.google.com/file/d/1fvzeU0z3LpT3aHUxCHj3mURrXPF37KhO/view?usp=sharing Per PF content guidelines - it's friendly, it explains the issue, and it tells the user what action(s) they should take to resolve the problem. |
@ibolton336 it seems this still relevant after non-admin features has been added. Moving forward. |
@gildub are you still planning to use this PR or should we close it? |
Closing due to lack of activity. |
Closes #756