Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumesForm: Replace Bullseye with Modal to handle critical errors #905

Closed
wants to merge 3 commits into from
Closed

VolumesForm: Replace Bullseye with Modal to handle critical errors #905

wants to merge 3 commits into from

Conversation

gildub
Copy link
Collaborator

@gildub gildub commented Jun 3, 2020

critical

Closes #756

@gildub gildub requested a review from a team June 3, 2020 18:43
@gildub
Copy link
Collaborator Author

gildub commented Jun 3, 2020

@vconzola, please let me know if that's what you'd expect.

@mturley
Copy link
Collaborator

mturley commented Jun 3, 2020

If I'm reading this code right, when the user clicks the "close" button on that modal it will just leave them with an empty wizard step, right? Maybe we want that button to say "Back" and move the wizard back a step when the modal closes?

Copy link
Collaborator

@vconzola vconzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gildub No this isn't what I had in mind. Let me create a mockup tomorrow.

@eriknelson eriknelson marked this pull request as draft June 15, 2020 17:07
@eriknelson
Copy link
Contributor

Converted this to a WIP PR since it's not ready. @vconzola do you have some updated mocks for @gildub ?

@vconzola
Copy link
Collaborator

@gildub The wording might not be exactly right, but this is what we want this sort of message to look like. https://drive.google.com/file/d/1fvzeU0z3LpT3aHUxCHj3mURrXPF37KhO/view?usp=sharing Per PF content guidelines - it's friendly, it explains the issue, and it tells the user what action(s) they should take to resolve the problem.

@gildub
Copy link
Collaborator Author

gildub commented Jun 26, 2020

@ibolton336 it seems this still relevant after non-admin features has been added. Moving forward.

@gildub gildub closed this Jun 26, 2020
@gildub gildub reopened this Jun 26, 2020
@mturley
Copy link
Collaborator

mturley commented Jul 13, 2020

@gildub are you still planning to use this PR or should we close it?

@ibolton336
Copy link
Contributor

Closing due to lack of activity.

@ibolton336 ibolton336 closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use appropriate alert types for controller errors
5 participants