Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2040695: Fix cluster name validation bug #1434

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

ibolton336
Copy link
Contributor

@ibolton336 ibolton336 requested a review from a team May 31, 2022 20:53
@openshift-ci
Copy link

openshift-ci bot commented May 31, 2022

@ibolton336: Bugzilla bug 2040695 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

Bug 2040695: Fix cluster name validation bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibolton336, mturley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley mturley merged commit 562e405 into migtools:master Jun 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

@ibolton336: All pull requests linked via external trackers have merged:

Bugzilla bug 2040695 has been moved to the MODIFIED state.

In response to this:

Bug 2040695: Fix cluster name validation bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mturley
Copy link
Collaborator

mturley commented Jun 1, 2022

@ibolton336 can you open a backport for this? We do already have a release-1.7.2 branch it seems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants