Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2038898: Adjust s3 initial values to match expected #1454

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Bug 2038898: Adjust s3 initial values to match expected #1454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/home/pages/StoragesPage/components/AddEditStorageModal/ProviderForms/S3Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ const valuesHaveUpdate = (values: any, currentStorage: IStorage, isAWS: boolean)
}

const existingS3URL = currentStorage.MigStorage.spec.backupStorageConfig.awsS3Url;
const existingRequireSSLValue = currentStorage.MigStorage.spec.backupStorageConfig.insecure;
const existingRequireSSLValue = !currentStorage.MigStorage.spec.backupStorageConfig.insecure;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requireSSL value needs to be !insecure as it is here:
https://github.com/konveyor/mig-ui/blob/186cc4f97cc178096b18348b33282ac02a1a24e0/src/app/home/pages/StoragesPage/components/AddEditStorageModal/AddEditStorageForm.tsx#L53
when the initial value is set.

This is causing the isDisabled check to always show false since these 2 values are not matching up in the case of an s3 repo. None of the other repos allow manual setting of the "insecure" value, so that is why this bug only shows up for s3 repos.

Same story for the customCA value. If the value does not exist, hard set it to null instead of allowing it to be undefined for comparison purposes.

const existingCABundleValue =
currentStorage.MigStorage.spec.backupStorageConfig.s3CustomCABundle;
currentStorage.MigStorage.spec.backupStorageConfig.s3CustomCABundle || null;

const valuesUpdatedObject =
values.name !== existingMigStorageName ||
Expand Down