Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Plan Wizard: Split resources into src, dst and replication #771

Closed
wants to merge 3 commits into from
Closed

[WIP] Add Plan Wizard: Split resources into src, dst and replication #771

wants to merge 3 commits into from

Conversation

gildub
Copy link
Collaborator

@gildub gildub commented Mar 24, 2020

WIP - Please DO NOT MERGE.

animation

Closes #724
Closes #765

@gildub gildub requested a review from a team March 24, 2020 21:20
@gildub gildub changed the title Add Plan Wizard: Split resources into src, dst and replication [WIP] Add Plan Wizard: Split resources into src, dst and replication Mar 24, 2020
@gildub
Copy link
Collaborator Author

gildub commented Mar 24, 2020

@vconzola, please let me know what you think.

Copy link
Collaborator

@vconzola vconzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gildub I didn't know you were working on this issue right now. Your work will conflict directly with the UXD changes @mturley is making to the wizard. Can we hold off on this for a bit? I need to re-think how the steps should be organized. I'd also like to make these changes at the same time we're addressing changes to be able to scale the UI to handle large numbers of namespaces #426.

@mturley
Copy link
Collaborator

mturley commented Mar 25, 2020

@vconzola your other reasons to hold off are valid, and @gildub we should communicate better so we don't step on each other's toes, but luckily I think this would not conflict with the stuff I'm working on for the PV and Storage Class wizard steps, since we're working in different files.

@eriknelson
Copy link
Contributor

I'd also like to make these changes at the same time we're addressing changes to be able to scale the UI to handle large numbers of namespaces #426.

@vconzola It's unlikely we're going to touch #426 until 1.3, certainly it's post-1.2.0.

Are we sure we want to wait until we're moving into June to split out this screen?

@vconzola
Copy link
Collaborator

@eriknelson Yes, I'd prefer to wait. As implement it would add two steps to the wizard, which with the hooks would mean we'd have an 8 step wizard and three of the first four steps would have only a single input field. I'd rather take some time and understand what fields can be combined in a step in way that makes sense from both a UX and controller standpoint. Also, the wizard works as is and we don't need to break the steps out until we tackle #426, so I think we should do them together.

@eriknelson
Copy link
Contributor

@vconzola ACK, makes sense.

@gildub Going to close this PR; I don't think there's going to be a lot here that can be reused and we're going to take a step back from a design standpoint and revisit this in a couple months.

@eriknelson eriknelson closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants