New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-1830: Only create VSR if it does not exist for a VSB #15
Conversation
@eemcmullan: This pull request references OADP-1830 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Spec: datamoverv1alpha1.VolumeSnapshotRestoreSpec{ | ||
ResticSecretRef: corev1.LocalObjectReference{ | ||
Name: vsb.Spec.ResticSecretRef.Name, | ||
// check if VolumeSnaphotRestore CR exists for VolumeSnaoshotBackup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// check if VolumeSnaphotRestore CR exists for VolumeSnaoshotBackup | |
// check if VolumeSnaphotRestore CR exists for VolumeSnapshotBackup |
GenerateName: "vsb-", | ||
Namespace: snapCont.Spec.VolumeSnapshotRef.Namespace, | ||
Labels: map[string]string{ | ||
util.BackupNameLabel: backup.Name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add backup UID here?
backup.Name isn't going to cause any issues here but it would be helpful to be able to compare if backup CR in the cluster still applies to this VSB.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eemcmullan, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick oadp-1.2 |
@shubham-pampattiwar: #15 failed to apply on top of branch "oadp-1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick oadp-1.2 |
@shubham-pampattiwar: new pull request created: #18 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also fixes VSB created per VSC