Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: use volumeOptions per storageClass #216

Merged
merged 2 commits into from May 10, 2023

Conversation

eemcmullan
Copy link
Collaborator

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@eemcmullan eemcmullan changed the title use storageClass per volumeOptions Design: use storageClass per volumeOptions May 9, 2023
@eemcmullan eemcmullan requested a review from weshayutin May 9, 2023 18:30
@eemcmullan eemcmullan changed the title Design: use storageClass per volumeOptions Design: use volumeOptions per storageClass May 9, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [eemcmullan,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eemcmullan eemcmullan merged commit 14b0e79 into migtools:master May 10, 2023
7 of 9 checks passed
@eemcmullan eemcmullan deleted the sc-design branch May 23, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants