Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-1151: Skip Deletion of ReplicationSource CRs #219

Merged
merged 1 commit into from May 17, 2023
Merged

OADP-1151: Skip Deletion of ReplicationSource CRs #219

merged 1 commit into from May 17, 2023

Conversation

shubham-pampattiwar
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar commented May 16, 2023 •
edited

Images you can use for testing:

dataMoverImageFqin: 'quay.io/spampatt/volume-snapshot-mover:keep-rs'
vsmPluginImageFqin: 'quay.io/spampatt/velero-plugin-for-vsm:dia-rs'

Related plugin PR: migtools/velero-plugin-for-vsm#16

@shubham-pampattiwar shubham-pampattiwar self-assigned this May 16, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 16, 2023 •
edited by openshift-ci bot

@shubham-pampattiwar: This pull request references OADP-1151 which is a valid jira issue.

In response to this:

Images you can use for testing:

dataMoverImageFqin: 'quay.io/spampatt/volume-snapshot-mover:keep-rs'
vsmPluginImageFqin: 'quay.io/spampatt/velero-plugin-for-vsm:dia-rs'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@shubham-pampattiwar shubham-pampattiwar mentioned this pull request May 16, 2023
Merged
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 16, 2023 •
edited by openshift-ci bot

@shubham-pampattiwar: This pull request references OADP-1151 which is a valid jira issue.

In response to this:

Images you can use for testing:

dataMoverImageFqin: 'quay.io/spampatt/volume-snapshot-mover:keep-rs'
vsmPluginImageFqin: 'quay.io/spampatt/velero-plugin-for-vsm:dia-rs'

Related plugin PR: migtools/velero-plugin-for-vsm#16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

weshayutin
weshayutin reviewed May 16, 2023
View reviewed changes
Copy link
Collaborator

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks .. afaik looks good

controllers/cleanup.go
@@ -20,7 +20,6 @@ var cleanupVSBTypes = []client.Object{
&snapv1.VolumeSnapshot{},
&snapv1.VolumeSnapshotContent{},
&corev1.Secret{},
&volsyncv1alpha1.ReplicationSource{},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah man.. I could done that :) /me runs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bingo

@weshayutin
Copy link
Collaborator

[~spampatt@redhat.com] 

After evoking the manual trigger by editing

triger.manual

In the expiry time frame the snapcontent was removed.
{code:java}
    storageClassName: gp2-csi
    volumeSnapshotClassName: csi-aws-vsc-test
  sourcePVC: snapcontent-259d65fb-eaca-47c9-a139-207fa46622d1-pvc
  trigger:
    manual: vsb-vnzxo
status:
  conditions:
  - lastTransitionTime: "2023-05-16T21:55:23Z"
    message: PersistentVolumeClaim "snapcontent-259d65fb-eaca-47c9-a139-207fa46622d1-pvc"
      not found
    reason: Error
    status: "False"
    type: Synchronizing
  lastManualSync: vsb-vnzxr-trigger
  lastSyncDuration: 23.569855118s
  lastSyncStartTime: "2023-05-16T21:55:23Z"
  lastSyncTime: "2023-05-16T21:40:26Z"
  latestMoverStatus:
    logs: |-
      no parent snapshot found, will read all files
      Added to the repository: 1.674 KiB (756 B stored)
      processed 3 files, 11 B in 0:00
      snapshot fafae839 saved
      Restic completed in 8s
    result: Successful
  restic: {}
{code}
 

 
{code:java}
**** S3 ****
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-0e3ed10f-90cb-4a64-abb1-151b112f57b6-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-21dade7d-ffd3-444a-ae4e-742b25e7a505-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-259d65fb-eaca-47c9-a139-207fa46622d1-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-2a868598-0bf1-405b-90d9-d6cf4b31dcc2-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-3b572fad-baf0-4cc4-9e2f-b031bf9d0383-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-40c15450-15a0-4244-b228-be80be8a5b19-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-4b7474de-8df1-4dda-9d52-f264a34b750b-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-9ff51252-7de1-4a57-9594-f192ec8aec65-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-f425de23-b988-4452-98e0-290e4cfe7a2e-pvc/
^C
[whayutin@thinkdoe minimal-8csivol]$ while true; do echo -e "RESTORE ONE \n;" echo "***** VSB "; oc get vsb -A; echo " VSC "; oc get vsc -A; echo " VS ";  oc get vs -A; echo " VSR *"; oc get vsr -A;  echo " S3 ****"; s3cmd ls s3://cvpbucket/openshift-adp/; sleep 15; done^C
[whayutin@thinkdoe minimal-8csivol]$ ls s3://cvpbucket/openshift-adp/
ls: cannot access 's3://cvpbucket/openshift-adp/': No such file or directory
[whayutin@thinkdoe minimal-8csivol]$ ls s3://cvpbucket/
ls: cannot access 's3://cvpbucket/': No such file or directory
[whayutin@thinkdoe minimal-8csivol]$ s3cmd ls s3://cvpbucket/openshift-adp/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-0e3ed10f-90cb-4a64-abb1-151b112f57b6-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-21dade7d-ffd3-444a-ae4e-742b25e7a505-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-259d65fb-eaca-47c9-a139-207fa46622d1-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-2a868598-0bf1-405b-90d9-d6cf4b31dcc2-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-3b572fad-baf0-4cc4-9e2f-b031bf9d0383-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-40c15450-15a0-4244-b228-be80be8a5b19-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-4b7474de-8df1-4dda-9d52-f264a34b750b-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-9ff51252-7de1-4a57-9594-f192ec8aec65-pvc/
                          DIR  s3://cvpbucket/openshift-adp/snapcontent-f425de23-b988-4452-98e0-290e4cfe7a2e-pvc/
[whayutin@thinkdoe minimal-8csivol]$ 
{code}

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@shubham-pampattiwar
Copy link
Member Author

Thanks for the update @weshayutin !

@shubham-pampattiwar
Copy link
Member Author

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link

@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [eemcmullan,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubham-pampattiwar shubham-pampattiwar merged commit 0dec66f into migtools:master May 17, 2023
8 of 9 checks passed
@openshift-cherrypick-robot
Copy link

@shubham-pampattiwar: new pull request created: #222

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshayutin weshayutin weshayutin approved these changes

@sseago sseago sseago approved these changes

@eemcmullan eemcmullan eemcmullan approved these changes

@kaovilai kaovilai Awaiting requested review from kaovilai

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@weshayutin weshayutin

@sseago sseago

@shubham-pampattiwar shubham-pampattiwar

@eemcmullan eemcmullan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shubham-pampattiwar @openshift-ci-robot @weshayutin @openshift-cherrypick-robot @sseago @eemcmullan