Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-1941: Remove securityContext default to true #230

Merged
merged 1 commit into from Jun 2, 2023

Conversation

eemcmullan
Copy link
Collaborator

No description provided.

@openshift-ci openshift-ci bot requested review from kaovilai and sseago June 2, 2023 17:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@eemcmullan eemcmullan changed the title Remove securityContext default to true OADP-1941: Remove securityContext default to true Jun 2, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 2, 2023

@eemcmullan: This pull request references OADP-1941 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [eemcmullan,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubham-pampattiwar
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@weshayutin
Copy link
Collaborator

data and file permissions are correct :) well done!

sh-4.4$ cd /var/lib/mysql/
sh-4.4$ ls -la
total 24
drwxrwsr-x. 4 root  mysql  4096 Jun  2 18:08 .
drwxr-xr-x. 1 root  root     53 Jun 20  2022 ..
drwxrws---. 6 mysql mysql  4096 Jun  2 18:08 data
drwxrws---. 2 root  mysql 16384 Jun  2 17:48 lost+found
srwxrwxrwx. 1 mysql mysql     0 Jun  2 18:08 mysql.sock
sh-4.4$ cat /etc/passwd | grep mysql
mysql:x:27:27:MySQL Server:/var/lib/mysql:/sbin/nologin
sh-4.4$ cat /etc/group | grep mysql
root:x:0:mysql
mysql:x:27:
sh-4.4$ 

@shubham-pampattiwar
Copy link
Member

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@shubham-pampattiwar
Copy link
Member

/cherry-pick oadp-1.2

@openshift-cherrypick-robot

@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f3057bd into migtools:master Jun 2, 2023
9 checks passed
@openshift-cherrypick-robot

@shubham-pampattiwar: new pull request created: #231

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants