Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-2074 Make PVC clone storageclass, accessmodes, resources consistent with sourcePVC #236

Closed
wants to merge 1 commit into from
Closed

OADP-2074 Make PVC clone storageclass, accessmodes, resources consistent with sourcePVC #236

wants to merge 1 commit into from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jun 8, 2023 •
edited

Make it so volumeOptionsForStorageClasses is for volsync operations only.

OADP-2074

Closes #235

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

@kaovilai
Make PVC clone storageclass, accessmodes, resources consistent with s…
3b9a2bb 
…ourcePVC

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@kaovilai kaovilai changed the title Make PVC clone storageclass, accessmodes, resources consistent with sourcePVC OADP-1821 Make PVC clone storageclass, accessmodes, resources consistent with sourcePVC Jun 8, 2023
@weshayutin
Copy link
Collaborator

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2023
@eemcmullan
Copy link
Collaborator

eemcmullan commented Jun 8, 2023 •
edited

@kaovilai @weshayutin this is the way we used to created the cloned PVC, and it does not work for the new CephFS feature

@kaovilai
Copy link
Member Author

kaovilai commented Jun 8, 2023 •
edited

it does not work for the new CephFS feature

So the inconsistent behavior seen in #235 is expected? @eemcmullan

@eemcmullan
Copy link
Collaborator

@kaovilai No - need to figure out why this happens. I tested yesterday with 10 backups and reproduced twice. It's odd

@kaovilai kaovilai changed the title OADP-1821 Make PVC clone storageclass, accessmodes, resources consistent with sourcePVC OADP-2074 Make PVC clone storageclass, accessmodes, resources consistent with sourcePVC Jun 8, 2023
@kaovilai
Copy link
Member Author

kaovilai commented Jun 8, 2023

My hunch is that the getConfigMap function used is returning nil (either error or configmap not found)when it shouldn't.

@shubham-pampattiwar
Copy link
Member

Closing this PR in favor of #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
4 participants
@kaovilai @weshayutin @eemcmullan @shubham-pampattiwar