Data down actions up. #66
Conversation
Refactor code to use `value` instead of `selection`. Now component can two way bind on the `value` property or send actions up and data down using the `selection’ property.
…ntent changes. I have decided using the data down actions up paradigm to be more manageable. change `selection` property to oneWay. remove `value` property.
|
@arenoir, please read the discussion in this PR and on this topic. Bottom line is that "Data down actions up" doesn't apply to every case. Also, even React allows these kind of things. Think about a long form with many selects. It would very cumbersome to write an action to each select instance. I think it would be a step backwards. I believe that this component would lose a lot of its usefulness if it only supports "Data down actions up" paradigm. I'm open for discussion, of course. |
|
Yes I agree there are cases for two way bindings and form elements are usually a good case. So until we can specify a property as mutable perhaps there should be an additional property to flag it as such |
|
That would be in line with #53. |
This pr changes the functionality of this addon significantly. It removes the
valueattribute and changesselectedto read only.At first I attempted to allow both "two way binding" or "oneway with actions" but failed to come up with a elegant way to differentiate between the two.
Personally I have come to the conclusion that the component should not mutate the object but only send actions and if I want the component to mutate a property I should wrap the component in another component and implement the mutation there.