make menu item support href

miguelcobain · Dec 15, 2017 · 1dcd802 · 1dcd802
1 parent 630f803
commit 1dcd802
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/addon/components/paper-menu-item.js b/addon/components/paper-menu-item.js
@@ -5,7 +5,7 @@ import Ember from 'ember';
 import layout from '../templates/components/paper-menu-item';
 import ChildMixin from 'ember-paper/mixins/child-mixin';
 
-const { Component } = Ember;
+const { Component, computed } = Ember;
 
 /**
  * @class PaperMenuItem
@@ -17,16 +17,18 @@ export default Component.extend(ChildMixin, {
   tagName: 'md-menu-item',
   disabled: false,
 
+  shouldRenderButton: computed.or('onClick', 'href'),
+
   actions: {
     handleClick(event) {
       this.get('dropdown.actions').close();
       this.sendAction('onClick', event);
     }
   },
+
   mouseEnter() {
     if (!this.get('disabled')) {
       this.$('button').focus();
     }
   }
-
 });
diff --git a/addon/templates/components/paper-menu-item.hbs b/addon/templates/components/paper-menu-item.hbs
@@ -1,5 +1,5 @@
-{{#if onClick}}
-  {{#paper-button onClick="handleClick" disabled=disabled}}
+{{#if shouldRenderButton}}
+  {{#paper-button onClick="handleClick" href=href target=target disabled=disabled}}
     {{yield}}
   {{/paper-button}}
 {{else}}