Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-basic-dropdown #1098

Closed
chbonser opened this issue Aug 12, 2019 · 12 comments
Closed

Upgrade ember-basic-dropdown #1098

chbonser opened this issue Aug 12, 2019 · 12 comments

Comments

@chbonser
Copy link
Contributor

ember-basic-dropdown made major changes in the 2.x release which is not currently compatible with ember-paper.

@xomaczar
Copy link
Contributor

And ember-power-select has been upgraded to v3.x and is incompatible with ember<3.11. Ember-paper is still in 1.beta cycle and tests all the way back to ember@2.18.
Are there any plans to cut 1.0 version, and start on 2.x which only supports Ember>=3.11

@LucasHillDex
Copy link

@miguelcobain we love this addon but the above question would be good to get a sense of. Is work on this addon stalled out? Does the community need to pull together to keep it going? What needs to happen to get to 1.0?

@esbanarango
Copy link

@miguelcobain Let us know if you want/need an extra ✋. 🙏

@betocantu93 betocantu93 mentioned this issue Nov 14, 2019
5 tasks
@miguelcobain
Copy link
Owner

The problem here is that newer versions of ebd/eps require ember 3.11.
I think that semver does not allow us to release ember-paper 1.0.0 with this breaking change: https://jubianchi.github.io/semver-check/#/^1.0.0-beta.26/1.0.0

So, in theory this should require a bump to 2.0.0, is that right?

Any suggestions?

@miguelcobain
Copy link
Owner

So, I rebuilt paper-menu, paper-select and paper-autocomplete using the new ebd and eps versions. It's on master.

All tests are passing, but it would be great if you guys could test these on your apps as well.

This also includes other changes like using html-next/vertical-collection instead of virtual-each. Also removes paper-virtual-repeat, encouraging the use of vertical-collection.

@betocantu93 this also includes some changes to these components directories.
Basically every paper-autocomplete-* component is now inside a paper-autocomplete directory.

This requires some updates on the blacklist/whitelisting feature that you built.
Could you please update it to work on the new directory structure?

Repository owner deleted a comment from alex9nadon Dec 27, 2019
@betocantu93
Copy link
Contributor

@miguelcobain great, on it. I think I don't need to worry about styles, right? those come from angular-material-styles and the treeForStyles logic should remain intact?

@miguelcobain
Copy link
Owner

@betocantu93 your work was also selectively importing the needed styles. But yes, everything regarding styles should still apply.

@betocantu93
Copy link
Contributor

betocantu93 commented Dec 27, 2019

@miguelcobain Here's the PR #1118

@LucasHillDex
Copy link

@miguelcobain I think a 2.0 release makes sense. A bit funny but, won't hose folks depending on the beta releases.

@miguelcobain
Copy link
Owner

After trying the branch for some time on our app, everything seems to work normally.
Released this in 1.0.0-beta.27.

@chbonser
Copy link
Contributor Author

chbonser commented Feb 7, 2020

@miguelcobain thanks for the release. Did the latest ember-basic-dropdown release add broader Ember support or does 1.0.0-beta.27 require > Ember 3.11? If so it might be worth a mention in the change log.

@miguelcobain
Copy link
Owner

@chbonser Yes, indeed ember-paper 1.0.0-beta.27 requires > Ember 3.11. I will add it to the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants