Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button sending action #11

Closed
altrim opened this issue Dec 10, 2014 · 3 comments
Closed

Button sending action #11

altrim opened this issue Dec 10, 2014 · 3 comments

Comments

@altrim
Copy link

altrim commented Dec 10, 2014

I am extending paper button in my component and I have a click function to handle an event, but I noticed after extending the paper button the action got sent twice.
When checking the code I saw the line below but I am not quite sure if I understand what action it sends and why? Is this intentional? After removing that it works fine and as expected.

https://github.com/miguelcobain/ember-paper/blob/master/addon/components/paper-button.js#L31

@miguelcobain
Copy link
Owner

This was some old code remainders.
Fixed now, thanks.

Why are you extending paper button, btw?
You can send whatever action you want and handle the event wherever you want.

@altrim
Copy link
Author

altrim commented Dec 11, 2014

Thanks for the fix. I have a bit more stuff handling in the button based on the model I get changing icons, styles, text and handling some events like mouseEnter and mouseLeave. So when installing ember paper wanted the same functionality but with the new material design.

Btw, when you are pushing the new version 0.0.5 to npm? The latest one is still 0.0.4.

@miguelcobain
Copy link
Owner

It should be published now.

If you find any custom behavior that could be a part of ember-paper, please open an issue. :)
Thanks.

mike-north pushed a commit to mike-north/ember-paper that referenced this issue Apr 17, 2015
default multiple to false, and maxItems to 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants