Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects not working in safari #31

Closed
miguelcobain opened this issue Feb 10, 2015 · 18 comments
Closed

Effects not working in safari #31

miguelcobain opened this issue Feb 10, 2015 · 18 comments
Labels

Comments

@miguelcobain
Copy link
Owner

@miguelcobain When I click a button, I see the background color change within a rounded rect and no animation.

@BryanHunt do you see any difference between http://miguelcobain.github.io/ember-paper/#/button and https://material.angularjs.org/#/demo/material.components.button ?

@altrim
Copy link

altrim commented Feb 10, 2015

I think @BryanHunt is using Safari. On the latest safari I am checking the effects are not working on buttons and same for switches, checkboxes and radio buttons are broken.

@miguelcobain
Copy link
Owner Author

Ember-paper or angular material or both?

@altrim
Copy link

altrim commented Feb 10, 2015

I am noticing just for ember-paper demo the issues. Angular material works fine on safari

@miguelcobain
Copy link
Owner Author

Ok, thanks.

Don't have my mac around right now. Will try to have a look when i do.

@BryanHunt
Copy link

Yep, I'm on a Mac using Safari :) Yep, effects seem to be broken. I see the effects on the Angular button but not the paper button. IMHO, the wave effect on the materialize site is better than the Angular one.

@miguelcobain
Copy link
Owner Author

Ok, thanks. Don't know what may be happening. 😕
Side note: the discussion should be which effect is closer to specs (I don't know that answer).

@BryanHunt
Copy link

Just to close out the side note. The Angular version seems to match the spec. I'm all for going with the spec.

@btecu
Copy link

btecu commented Feb 11, 2015

Not just the effects but most of the things seem broken in Safari:

screen shot 2015-02-10 at 7 23 35 pm

screen shot 2015-02-10 at 7 23 48 pm

screen shot 2015-02-10 at 7 31 05 pm

@miguelcobain miguelcobain changed the title button wave effect Effects not working in safari Feb 11, 2015
@BryanHunt
Copy link

I think the problem is more fundamental than effects. It looks like the CSS is very broken in general on Safari - there are no headers on the sample application at all. Looks great under Chrome.

@miguelcobain
Copy link
Owner Author

I could use some help in finding this bug. What kind of headers are missing?

@BryanHunt
Copy link

Here is a screenshot of what I get when I open http://miguelcobain.github.io/ember-paper/

ember-paper_-the_ember_approach_to_material_design

@BryanHunt
Copy link

And here is the computed style for md-nav-container as an example.

ember-paper_-the_ember_approach_to_material_design

@green-arrow
Copy link

@BryanHunt @miguelcobain looks like the root problem is Safari not understanding display: flex. By adding display: -webkit-flex, things start looking better. Looks like we need to just add in the -webkit prefix for flexbox layouts in order for this to work in Safari.

I think pulling in Autoprefixer and running that against our CSS would solve the issue nicely.

@miguelcobain
Copy link
Owner Author

What about this https://github.com/kimroen/ember-cli-autoprefixer ?
Our sass compilation is currently a "workaround", so it may not make sense to use this addon.

miguelcobain added a commit that referenced this issue Feb 13, 2015
@green-arrow
Copy link

I'd have to read up on how to inject properties into EmberApp. I've never used an addon within an addon before 😛

For this pass I just wanted to follow the patten you were already using in postinstall.sh.

@miguelcobain
Copy link
Owner Author

Let's stick with this for now.
I'm hoping to have a better sass build approach when this is solved: ember-cli/ember-cli#2905

@green-arrow
Copy link

Sounds like a plan.

@BryanHunt
Copy link

AwesomeSauce!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants